Bugfix/upgrade rxjs and change imports to match docs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bryphe this PR attempts to fix issues when using the
oni-typespackage outside of oni-core which brings up the issue withSubjectimport from RxJSI think that the issue here might have been that the package had
rxjsspecified as a dev dependency not a dependency which might have lead to why it couldn't be resolved.I took the opportunity (in case the issue also relates to import paths) to upgrade rxjs to v6 which has changed the import paths so
Subjectis now imported fromimport { Subject } from 'rxjs'Hopefully this resolves import issues including the issue im facing in onivim/oni/pull/1310