Add structured response model #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved formatting and readability of comments in OllamaAPI.java. - Introduced OllamaStructuredResult class to handle structured responses from the Ollama API. - Updated integration tests to include a new test for structured output from the API. - Cleaned up imports and ensured consistent code style across the OllamaAPIIntegrationTest class.
Closed
- Updated OllamaAPI to return an instance of OllamaResult instead of OllamaStructuredResult for structured responses. - Removed the obsolete OllamaStructuredResult class. - Added new methods in OllamaResult for retrieving structured responses as a Map or mapped to a specific class type. - Updated integration tests to validate the new structured response functionality. - Improved Makefile with a new full-build target for building the project.
- Added a note in the README.md to guide Windows users on installing Chocolatey Package Manager and using it to install `make`. - Suggested running the installation command with administrator privileges for better success.
- Updated the Makefile to include a new target for local integration tests with external Ollama host configuration. - Modified the OllamaAPIIntegrationTest to dynamically set the Ollama host based on environment variables, allowing for both external and Testcontainers usage. - Refactored model pulling logic in tests to use constants for model names, improving readability and maintainability.
Signed-off-by: Amith Koujalgi <koujalgi.amith@gmail.com>
…uctured responses - Added a retry mechanism in OllamaAPI for model pulling, allowing configurable retries. - Introduced new methods in OllamaResult for structured response handling, including parsing JSON responses into a Map or specific class types. - Updated integration tests to validate the new functionality and ensure robust testing of model interactions. - Improved code formatting and consistency across the OllamaAPI and integration test classes.
Added support for structured output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate()method that takes a structured output definition as aMapand returnsOllamaStructuredResultfrom the Ollama API.