gptoss: enable flash attention by default #11996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the PR title is misleading, as it doesn't change anything about KV cache quantization. |
jessegross
reviewed
Aug 20, 2025
|
updated pr title and commit message. it's an artifact of the original commit as are some of the changes |
3272208 to
7c80562
Compare
jessegross
previously approved these changes
Aug 20, 2025
|
Actually, the estimate for gpt-oss needs to be conditional on flash attention if it might be disabled on some hardware. |
Actually, the estimate for gpt-oss needs to be conditional on flash attention if it might be disabled on some hardware.
|
there isn't currently a mechanism to have different estimates for flash attention and I'm reluctant to add one give new estimates so going to revert that portion of the changes |
jessegross
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change enables flash attention by default for gpt-oss