refactor: use slices.Equal to simplify code #11502
Merged
+2
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: minxinyi <minxinyi6@outlook.com>
gabe-l-hart
added a commit
to gabe-l-hart/ollama
that referenced
this pull request
Jul 25, 2025
* origin/main: cli: catch upstream errors gracefully (ollama#11512) tools: loosen tool argument parsing (ollama#11509) server: use slices.Equal to simplify code (ollama#11502) s#x/exp/maps#maps# (ollama#11506) Fix GetModelInfo (ollama#11496) Update linux.md (ollama#11462)
paulnegz
added a commit
to paulnegz/slang
that referenced
this pull request
Jul 29, 2025
….Equal * Implements SliceEqualSimplificationCheck to detect custom slice equality functions that can be replaced with Go's built-in slices.Equal() function * Detects functions with 2 parameters that contain len() comparisons * Includes comprehensive test coverage with SLang syntax examples * Addresses refactoring opportunity similar to ollama/ollama#11502 This rule helps Go developers modernize their code by identifying opportunities to use the standard library's optimized slice comparison instead of custom implementations.
|
@minxinyi love this fix! Just contributed a new rule to SonarSource that will help Go developers (including future Ollama contributors) automatically identify opportunities to refactor custom slice equality functions to use slices.Equal(). |
rick-github
pushed a commit
to rick-github/ollama
that referenced
this pull request
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Go 1.21 standard library, a new function has been introduced that enhances code conciseness and readability. It can be find here.