Enhance DestroyPreview functionality to include timeout parameter #4745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the Destroy method in the preview client to accept a timeout parameter, allowing for more flexible preview destruction. - Modified related interfaces and test cases to accommodate the new timeout argument. - Adjusted error handling in the Destroy method to manage cases where the timeout argument is not recognized. This change improves the usability of the DestroyPreview feature by enabling users to specify a timeout for the operation. Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4745 +/- ##
==========================================
- Coverage 48.91% 48.88% -0.03%
==========================================
Files 356 356
Lines 29809 29819 +10
==========================================
- Hits 14582 14578 -4
- Misses 14066 14077 +11
- Partials 1161 1164 +3 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes DEV-980
This change improves the usability of the DestroyPreview feature by enabling users to specify a timeout for the operation.
How to validate
I run
okteto preview deploy 10mon the repo https://github.com/jLopezbarb/movies/tree/jlo/destroy-10m and thenokteto preview deploy 10mand got as result:CLI Quality Reminders 🔧
For both authors and reviewers: