Skip to content

fix: update SYNCTHING_VERSION to 1.29.6 and add syncthing data volume mounts #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

fix: update SYNCTHING_VERSION to 1.29.6 and add syncthing data volume mounts #4711

merged 1 commit into from
May 8, 2025

Conversation

jLopezbarb
Copy link
Contributor

Signed-off-by: Javier Lopez javier@okteto.com

Proposed changes

Fixes DEV-900

Updates to the lastest syncthing version. We couldn´t update because the data volume folder was missing and we were not storing that.

How to validate

  1. Build the CLI and push it to your registry
  2. Run export OKTETO_BIN=$YOURIMAGE
  3. Create a new namespace
  4. Run okteto up on any of your repos and check that it starts correctly

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

@jLopezbarb
fix: update SYNCTHING_VERSION to 1.29.6 and add syncthing data volume…
ed6d7a7 
… mounts

Signed-off-by: Javier Lopez <javier@okteto.com>
@jLopezbarb jLopezbarb requested a review from a team as a code owner May 6, 2025 12:30
@codecov Codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.86%. Comparing base (a0213b8) to head (ed6d7a7).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4711   +/-   ##
=======================================
  Coverage   48.85%   48.86%           
=======================================
  Files         354      354           
  Lines       29522    29527    +5     
=======================================
+ Hits        14424    14429    +5     
  Misses      13952    13952           
  Partials     1146     1146
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jLopezbarb jLopezbarb added the run-e2e When used on a PR run windows & unix e2e label May 7, 2025
@jLopezbarb jLopezbarb merged commit 9a308d2 into master May 8, 2025
32 of 34 checks passed
@jLopezbarb jLopezbarb deleted the jlo/update-syncthing-to-1.29.6 branch May 8, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifbyol ifbyol ifbyol approved these changes

Assignees
No one assigned
Labels
release/internal run-e2e When used on a PR run windows & unix e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jLopezbarb @ifbyol