feat: add destroy with dependencies on CLI #4718
Conversation
Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4718 +/- ##
==========================================
- Coverage 48.83% 48.79% -0.04%
==========================================
Files 354 354
Lines 29572 29567 -5
==========================================
- Hits 14442 14428 -14
- Misses 13981 13989 +8
- Partials 1149 1150 +1 🚀 New features to boost your workflow:
|
pkg/okteto/pipeline.go
Outdated
| } | ||
| } else { | ||
| var mutation destroyPipelineWithoutVolumesMutation | ||
| var mutation destroyPipelineWithoutVolumesMutationAndDependencies |
There was a problem hiding this comment.
Minor thing, but why don't we unify both branch and just send destroyVolumes: false when the destroy flag is not set? It would simplify the code. Not needed to tackle, but wondering why it is done like that?
There was a problem hiding this comment.
We need to handle the case where the graphql doesn't support the flag, that's why I have to create 2 new structs
There was a problem hiding this comment.
We are not handling the case of destroyVolumes variable not supported, right?. We just check if the option is passed or not to add it or not in the query
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez <javier@okteto.com>
Signed-off-by: Javier Lopez javier@okteto.com
Proposed changes
Fixes DEV-941
Adds the ability to run
okteto pipeline destroy --dependenciesfrom the CLI and call the correct graphql endpointHow to validate
With a cluster that has the correct configuration and CLI
CLI Quality Reminders 🔧
For both authors and reviewers: