PROD-344: Add predefined Okteto environment variables to diverted pods, so it can be known at runtime time if they are in a diverted namespace or not #4699
Conversation
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4699 +/- ##
==========================================
+ Coverage 48.75% 48.84% +0.08%
==========================================
Files 354 354
Lines 29480 29510 +30
==========================================
+ Hits 14374 14415 +41
+ Misses 13960 13949 -11
Partials 1146 1146 🚀 New features to boost your workflow:
|
Signed-off-by: Nacho Fuertes <nacho@okteto.com>
|
Tested and it's working but I have one question. If I do a |
I don't think so. The idea of having those environment variables is that user's application might used them in some scenarios, like to decide to which queue should be connected based on a message header. In our init containers, at least for now, we don't need those environment variables, as our logic doesn't need them. But for the ones specified by users, might be necessary, for example, if they want to pre-load some data in a database |
PROD-344
Description
This PR adds two environment variables to the divert drivers (nginx and istio) to provide information about the shared and diverted environments:
Changes made:
Added two new constants in pkg/constants/constants.go:
Modified the UpdatePod function in both divert drivers:
Added a helper function updateEnvVar to both drivers to handle adding or updating environment variables.
Added comprehensive unit tests for both drivers:
Testing:
This change will allow applications running in diverted environments to be aware of both the shared and diverted namespaces, which can be useful for various integration scenarios.