Adding pagination to apps API call to support more than 200 amazon_aws apps #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried this code and it works great with pagination support and returns a full list of amazon_aws apps |
|
I brought this code in on #213 and extended it with a technique from okta-sdk-golang to fetch different types of object lists so we could easily support non-Admin users when the OIDC app has been granted the Released as v2.2.0 https://github.com/okta/okta-aws-cli/releases/tag/v2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix/enhancement to okta-aws-cli to pagination the call to /api/v1/apps instead of limiting to 200