feat: Add strong name signing to Okta.AspNetCore assembly #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranav-okta
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #244 introduces strong name signing to the Okta.AspNetCore assembly. This resolves issues encountered when referencing Okta.AspNetCore from other strongly named assemblies, particularly in .NET 6.0+ projects.
The changes include:
Adding a public key file (okta.aspnet.snk).
Enabling assembly signing and specifying the key file in the Okta.AspNetCore.csproj.
Implementing delayed signing for development builds.
(If applicable) Updating InternalsVisibleTo attributes in AssemblyInfo.cs to include the public key of related test assemblies.
(If applicable) Outlining necessary build server configurations for full strong name signing using a private key.
(If applicable) Providing instructions for developers to enable local debugging of partially signed assemblies.
This change aligns with the approach taken in the okta-aspnet repository (as seen in the linked issue and related pull request) to ensure better compatibility and integration with strongly named .NET ecosystems.