Fix: Replace RuntimeInformation dependency with Environment.Version for .NET 8+ #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-rodriguez
requested changes
Jan 7, 2025
|
Thanks for the feedback, Laura. I've updated the test to directly call UserAgentHelper.GetFrameworkDescription. The part (".NET Core foo", "foo/Microsoft.NETCore.App") wasn't necessary, as my goal was to test the FrameworkDescription based on .NET versions. The updated test now achieves that. I also ensured that all other tests are passing to confirm that the existing functionality is intact. Please let me know if you think any further changes are needed. |
51614ab to
ffd8b44
Compare
ffd8b44 to
a80050f
Compare
laura-rodriguez
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
LGTM 👍
Thank you for making these changes, @aniket-okta!
The next step will be releasing a patch and updating the abstractions dependency in both ASP.NET SDKs 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue related to the use of RuntimeInformation.FrameworkDescription in the UserAgentHelper class of the Okta.AspNet.Abstractions library. The change replaces the dependency on RuntimeInformation with Environment.Version for projects targeting .NET 5 and above. The goal is to reduce unnecessary dependencies, especially in modern .NET versions, by utilizing Environment.Version to obtain framework version details.
Changes Made:
Testing Done:
Related Issues:
-#274