Skip to content

do not save draft text when adding new recipients to group convo #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

do not save draft text when adding new recipients to group convo #356

merged 1 commit into from
Mar 15, 2025

Conversation

gavine99
Copy link
Contributor

change to not save sms body input text as draft between adding new recipients to sms on compose screen.

solves issue below, but also in the following scenario;

  1. click floating + button on main activity (new sms)
  2. select a contact/existing convo
  3. start typing text into sms body input box
  4. add a new contact/existing convo
  5. previously, the text entered before the second recipient was added was saved as draft in first added contact's convo, now it isn't

closes #187

@gavine99
Copy link
Contributor Author

@octoshrimpy every time i see this ci check
image
i think to myself 'of course they weren't detected.... they're secret' heh

@octoshrimpy octoshrimpy merged commit 71c5aa4 into octoshrimpy:master Mar 15, 2025
2 checks passed
@gavine99 gavine99 deleted the duplicate-drafts-for-first-member-of-group-messages-187 branch March 17, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] duplicate drafts for first member of group messages
2 participants
@gavine99 @octoshrimpy