fix new conversation not created for non-send-as-group multi-recipient message #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…activity) when sending from a new convo as group. also fix associated bug that was sending sms to individual recipients in 'send as group mode' when send as group pref was saved as true
…o member of a multi-recipient sms not sent as group
…end-320-haserror-sendasgroup-fix fix bug causing compose activity to finish() when it wasn't supposed to
…k-fix Remove `DependencyInfoBlock` in APK
|
conflicts, otherwise looks good. :) |
added 2 commits
March 13, 2025 10:08
…o member of a multi-recipient sms not sent as group
…'t-start-new-conversations' into send-to-multiple-addresses-doesn't-start-new-conversations # Conflicts: # presentation/src/main/java/com/moez/QKSMS/feature/compose/ComposeViewModel.kt
|
rebased pr to latest master and should be ready to pull |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix no creation of a new conversation when no existing conversation to member of a multi-recipient sms not sent as group.
steps to reproduce existing bug;
encountered this bug whilst testing for pr #344