Skip to content

Conversation

Inhishonor
Copy link
Collaborator

This pr updates all the versions in the build-on-pull.yml. Note, this does not actually make this action succeed. It only allows the build to start. The build then makes it about 3/4 of the way through and fails with a signing keys error. I am currently working on this, but I have not made much headway. My apologies @Ilithy for jumping in on this. Thanks!

Update's versions.
@Inhishonor
Copy link
Collaborator Author

I am very sorry, I realized I should have made this a draft until I get the build to actually work. Very sorry, I am still new to git...

@Inhishonor Inhishonor marked this pull request as draft January 29, 2025 17:31
@octoshrimpy
Copy link
Owner

@Inhishonor no worries! we are all learning here! Go ahead and mark it as ready whenever you are. :)

Update Versions and add code to add the signing keys to the build.
@Inhishonor
Copy link
Collaborator Author

@octoshrimpy Is the code that injects the signing keys right? I merely copied and pasted it from another action in this repo. I am not sure how the secrets are labeled within the secrets file.

@octoshrimpy
Copy link
Owner

I believe that is correct.

Fixes the formatting of the keystore injections.
Changes it to only set up a NoAnalyticsDebug.
Remove --stacktrace.
@Inhishonor
Copy link
Collaborator Author

I was able to get it to successfully run. To do so, I had to only build a No Analytics build, as there are too many deprecations and errors in the Analytics build. As of right now, the code says to upload artifacts (test results) to a folder, however the folder doesn't exist. If you don't need that I could remove that from the code. But at this point it should work.

@Inhishonor Inhishonor marked this pull request as ready for review February 9, 2025 20:36
@octoshrimpy octoshrimpy merged commit 09fe37b into octoshrimpy:master Feb 10, 2025
2 checks passed
@Inhishonor Inhishonor deleted the update-build-on-pull branch February 10, 2025 15:34
@octoshrimpy
Copy link
Owner

image

running into a bit of a problem: I believe it's attempting to upload from the wrong build directory. otherwise it's very nice having the green checkmark, thank you for all your hard work!

@Inhishonor
Copy link
Collaborator Author

I will work on that, and no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants