Hi @gr2m @NickLiffen ! Is this still a plan? Or it's too complicated to handle and there won't be an official pagination helper? octokit/graphql.js#61 (comment)

I would be interested in collaborate on it if it's going to move forward and if it's possible.

Thanks

Right now I think it's too complicated. We'd probably be better of by creating good tutorials on how to paginate with the current octokit.graphql API. Once we have some good tutorials, we can try to find patterns that might be helpful to codify in a plugin.

Right now I think it's too complicated. We'd probably be better of by creating good tutorials on how to paginate with the current octokit.graphql API. Once we have some good tutorials, we can try to find patterns that might be helpful to codify in a plugin.

Yep,I read the thread on the original issue. I just wanted to know if there were news on this. Maybe this repo should be archieved?

Thanks for your answer!

I didn't give up hope just yet. I intend to write some tutorials myself, unless someone beats me to it ;)

I didn't give up hope just yet. I intend to write some tutorials myself, unless someone beats me to it ;)

I have zero knowledge on GraphQL right now but I’m catching up with it (as doing with TypeScript xD) so if you think I can help to draft these docs... I’m in! :)

Here is the recording of Rea's talk I mentioned in the thread at octokit/graphql.js#61
https://www.youtube.com/watch?v=i5pIszu9MeM

Basically I'd convert these to a set of tutorials. Giving Rea full credit of course.

Here is the recording of Rea's talk I mentioned in the thread at octokit/graphql.js#61

https://www.youtube.com/watch?v=i5pIszu9MeM

Basically I'd convert these to a set of tutorials. Giving Rea full credit of course.

I watched the talk yesterday. Super cool talk. Ok about the tutorials but... not sure which structure to follow. Is there any other repo on Octokit with tutorials to follow the approach?

I will draft an index proposal so we can start discussing it! :)

not sure which structure to follow. Is there any other repo on Octokit with tutorials to follow the approach

Not really, I wish there was though. I published a few tutorial-esque posts to https://dev.to/gr2m/. If you write some up we can just list them in the README.md of https://github.com/octokit/graphql.js for now

not sure which structure to follow. Is there any other repo on Octokit with tutorials to follow the approach

Not really, I wish there was though. I published a few tutorial-esque posts to https://dev.to/gr2m/. If you write some up we can just list them in the README.md of https://github.com/octokit/graphql.js for now

Sure! Let me draft some initial posts and we can discuss it together :)

@gr2m we have this wonderful pagination script over at release-drafter:
https://github.com/release-drafter/release-drafter/blob/master/lib/pagination.js

Should be flexible enough for most cases. Apart from sub pagination but could properly be fixed easily.
See usage here: https://github.com/release-drafter/release-drafter/blob/master/lib/commits.js

Thanks a lot for sharing Joseph! I've currently very limited availability, but I will get back to you. I'm looking forward to it!

@jetersen I was wondering if we could avoid the extra paginatePath parameter by enforcing a naming convention of the cursor variables, see my comment here: octokit/graphql.js#61 (comment)

In the case of your query at https://github.com/release-drafter/release-drafter/blob/master/lib/commits.js, instead of using $after, the variable could be called $cursor_repository_ref_target_history. What do you think?

@gr2m I am all for generalizing graphql pagination! Having conventions for cursor variables would make absolute sense and would even support sub pagination :)

Hi @gr2m! can I help here with anything?

I use GraphQL pagination in a few places in my code and have this functionality reimplemeted a couple of times. It would be nice to have it as a reusable plugin.

Absolutely! It’s all yours :) And you’d be perfect to build it as you have the real life examples as a test

If it helps, this is how we are thinking about implementing it for our github singer tap
MeltanoLabs/tap-github#118

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀