Remove inline qualifiers inside .cpp #291
Conversation
Remove inline qualifiers inside .cpp
|
Thanks. I just recently added those when I split the file and guessed it would probably be invalid somewhere. Do you have any recommendation on how to guarantee those inlined within the imgui.cpp compilation unit at least? At least GetCurrentWindow() seems inline in my VS2010 release build but I am equally concerned about the effect on most-unoptimized builds (e.g. those where VS2010 is putting markers in the callstack; but then I don't think any inline marker would help.). I might just move GetCurrentWindow() and the ItemSize() variation to imgui_internal.h as static inline. |
|
I'm not aware of a portable way to ensure inlining without the use of a macro - the inline keyword is a hint, and even static does not assure inlining (e.g. gcc doesn't inline a trivial static inline function at -O0) Is there a particular case you know of where forcing inlining of these functions is clearly beneficial? |
|
as @twoscomplement points out inline is a hint (__forceinline) seems to be quite "forceful" under MSVC but to have this portable they need to be inside a header. |
|
I suppose the only real thing I'm concerned about are performances with typical Debug settings. Anyway none of those few functions you touched are worth the trouble here, they are minor stuff and even GetCurrentWindow() isn't worth the trouble. (the ones that really mattered in the rendering code where already moved straight in the code as I didn't find a way to force inlining for them - I may reorganise those as macros later) |
Use of inline in the .cpp file causes link errors with gcc.
Includes my merged PRs and everything in my dev branch. Haven't tested with it yet. Changelog: Test case for clip rect HACK: more recent Windows SDK and VS2017; disable graph Set size to amount of space required Merge pull request ocornut#349 from maksw2/master Merge pull request ocornut#347 from mgerhardy/341 Merge pull request ocornut#348 from mgerhardy/fixed-warning Merge pull request ocornut#346 from mgerhardy/280 Merge pull request ocornut#345 from mgerhardy/322 Merge pull request ocornut#344 from rherilier/fix-gcc-warnings Merge pull request ocornut#336 from rherilier/add-isusingviewmanipulate Merge pull request ocornut#335 from RedSkittleFox/alternative_window Merge pull request ocornut#334 from ocornut/fix-beginchildframe dear imgui update and small fixes Merge pull request ocornut#316 from Batres3/2DSupport Merge pull request ocornut#326 from Sayama3/use-push-pop-id Merge pull request ocornut#328 from georgeto/master Merge pull request ocornut#330 from maritim/master Merge pull request ocornut#331 from GiovanyH/patch-1 Merge pull request ocornut#318 from dougbinks/imgui_math_operators Merge pull request ocornut#312 from kimidaisuki22/master div 0 fixed Merge pull request ocornut#301 from ZingBallyhoo/using-any Merge pull request ocornut#300 from Clog41200/Configurable-limits Merge pull request ocornut#298 from xDUDSSx/fix/rotation_circles Merge pull request ocornut#297 from xDUDSSx/fix/vertical-aspect-scaling Merge pull request ocornut#289 from ComputationalBiomechanicsLab/fix_isusing-ignores-setid Merge pull request ocornut#291 from ocornut/fix_math_operators_include Merge pull request ocornut#282 from MohitSethi99/master Merge pull request ocornut#276 from pthom/virtual_destructors Merge pull request ocornut#271 from idbrii/clip-parent Merge pull request ocornut#270 from idbrii/btn-behaviour Merge pull request ocornut#265 from mgerhardy/pr/fix-minor-formatting Merge pull request ocornut#264 from mgerhardy/pr/div0 Merge pull request ocornut#269 from peter1745/hatched-line-thickness-enhancement Merge pull request ocornut#259 from miyanyan/master Merge branch 'master' of https://github.com/CedricGuillemet/ImGuizmo update dear imgui Merge pull request ocornut#256 from Aidiakapi/patch-1 Merge pull request ocornut#252 from aaronkirkham/master Merge pull request ocornut#249 from rokups/rk/mouse-capture Merge pull request ocornut#246 from mgerhardy/pr/viewmanipulate removed commented code fix click view cube Merge pull request ocornut#231 from mgerhardy/master Merge pull request ocornut#230 from mgerhardy/master Merge pull request ocornut#228 from longod/master Merge pull request ocornut#227 from madeso/master AddBezierCubic Merge pull request ocornut#226 from sherief/master revert culling test commit Merge pull request ocornut#203 from rokups/rk/misc-fixes Merge pull request ocornut#212 from zhaijialong/fix-behind-camera-cull Merge pull request ocornut#209 from VictorFouquet/fix_normalize scale is always local Merge pull request ocornut#202 from pezy/master imguizmo namespace Merge pull request ocornut#194 from JonathanHiggs/vcpkg-example 1.84 WIP Merge pull request ocornut#197 from idbrii/seq-btn-color Merge pull request ocornut#196 from idbrii/seq-big-handles
Use of inline on externally-visible functions in imgui.cpp causes link errors when compiling imgui_demo.cpp with gcc.