Vulkan backend: remove call to RemoveTexture() #7307
Conversation
|
For reference, the mentioned validation error is listed in the documentation here: |
|
Hello Shawn,
Going onward we will absolutely require the Note that 61ab94d about 40 days ago added an option to let the backend automatically create the pool, by setting For both reasons I don't think we need to merge this anymore. |
|
Hey @ocornut, thanks for following up! Yes, I agree this is no longer needed. My workaround was just to create a dedicated pool for ImGui, in which case I felt that the API should make it clear to do that, or even better create it for you. That's exactly what Arseny's change does - great! :) |
RemoveTexture()tries to free a descriptor set on shutdown, which requires the caller to provide a descriptor pool with VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT set. If the pool does not have this set, it is a validation error. I don't think this is a restriction the backend should impose. Since it's the caller's responsibility to provide the pool, it should be the caller's responsibility to free the pool on shutdown (which frees the descriptor sets therein).The easiest way to integrate with this Vulkan backend is to take your existing descriptor pool (used for whatever else in your application), accommodate the necessary space for what ImGui needs, and provide that. Removing the requirement for the aforementioned bitmask flag allows you to do so without having to change the characteristics of your pool.