Imstr #683
Closed
Imstr #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial experimental support for API that doesn't require null terminated strings. It compiles but there are bugs, and there's still some char* buffers to deal with.
There are some function signatures which have changed which still work with the old parameters. Might need to keep the old versions around to avoid unexpected issues.
Some user code may be relying on these being around, so keep them for now.
The strlen is now calculated on demand with CalculateEnd() instead of implicitly in the ImStr constructors.
The slice and char* of the same string containing '###' was generating a different hash.
Plots and Menu shortcuts.
String slices can't be used as printf format strings as they aren't null terminated, so for now no formatting functionality is provided for the ImStr text widgets. In the case of FFI it is expected that strings will already be formatted when they're passed to ImGui.
Fixes to cimgui C API builds without modification, to preserve compatibilty with existing API. I haven't tested any of these new code paths yet!
|
As much as I like the idea, it has has the problem that it breaks all wrapper code for imgui, and I am considering to write a wrapper right now at this moment. |
|
You'd just need to update the binding to also pass the string length instead of just a pointer to a string |
|
@krux02 The main motivation for this change was for calling dear imgui from Rust (as Rust strings are not null-terminated). As part of this work I have also branched cimgui (a C imgui wrapper) to support these changes at https://github.com/bitshifter/cimgui/tree/imstr. |
|
An idea to not create breaking changes is to make #ifdef USE_IM_STR_STRUCT
struct ImStr
[...]
#else
using ImStr = const char*;
#endif |
|
Closing as moved to #3038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking PR for issue #494.