Fix Alt+Enter fullscreen in DirectX 12 example. #4347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing while I investigate a quirk I found. |
|
TL;DR: Had a false alarm on a bug in this change. Found unnecessary device object recreation in the process. I finished investigating the quirk. While testing this change with the docking branch I noticed a debug layer crash happening in I did not determine the root cause of the crash (other than that it is specific to the docking backend -- will investigate more later), but it did make me realize I got tunnel vision and did not notice this unnecessary destruction/creation of backend-owned device objects. Since this PR is already touching this area and it is related to window resizing, I removed those calls as well. |
This was referenced Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was superseded by #4348
This PR fixes #4346
Not sure why this example was recreating the entire swap chain on resize (it's been like that forever), but
ResizeBuffersis the correct way to react toWM_SIZE.Only the Direct3D 12 sample was affected, other samples and viewport-aware backends are fine: