-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
Description
Version/Branch of Dear ImGui:
Version: 1.72b
Branch: docking
Back-end/Renderer/Compiler/OS
Back-ends: imgui_impl_win32.cpp + imgui_impl_dx11.cpp
Compiler: Visual Studio 2017
Operating System: Windows 10
My Issue/Question:
This issue is in response to #787. As of recently with the added gamepad inputs, Dear ImGui added a pragma link to the source to automatically link to xinput
:
#ifdef _MSC_VER
#pragma comment(lib, "xinput")
#endif
This will cause MSVC to link against xinput1_4.dll
, which is not available on Windows 7. (It probably will link against 1.3 or the strangely named "9.1.0" if you're building on a Windows 7 machine though.)
Since there are 3 possible versions of xinput, I propose a possible fix where we link with xinput 9.1.0 instead, which is shipped both within the 8.1 SDK and up, and on Windows 7 and up.
#ifdef _MSC_VER
#pragma comment(lib, "Xinput9_1_0")
#endif
It's a bit weird that this is even required, but this will cause MSVC to link against Xinput9_1_0.dll
, which seems to be available everywhere.