test: enabled_if with dune describe crash #10778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Jul 29, 2024
| Description: | ||
| ("modules_and_obj_dir: failed lookup", | ||
| { keys = []; for_ = Exe { first_exe = "test" } }) | ||
| Raised at Stdune__Code_error.raise in file |
There was a problem hiding this comment.
Please remove the stacktrace from the test output.
97f7b69 to
bd14d58
Compare
rgrinberg
reviewed
Jul 30, 2024
| > (executable | ||
| > (name test) | ||
| > (enabled_if | ||
| > (= %{system} macosx))) |
There was a problem hiding this comment.
Can you use a different value than macosx? Otherwise the test actually fails on macos
bd14d58 to
d904a49
Compare
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
d904a49 to
9bc5d30
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Alpha DIALLO <moyodiallo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.