Skip to content

Conversation

megies
Copy link
Member

@megies megies commented Feb 3, 2023

What does this PR do?

Updates the URL for raspberryshake FDSN WS

Why was it initiated? Any relevant Issues?

fixes #3263

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • While the PR is still work-in-progress, the no_ci label can be added to skip CI builds
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just add the build_docs tag to this PR.
    Docs will be served at docs.obspy.org/pr/{branch_name} (do not use master branch).
    Please post a link to the relevant piece of documentation.
  • If all tests including network modules (e.g. clients.fdsn) should be tested for the PR,
    just add the test_network tag to this PR.
  • All tests still pass.
  • Any new features or fixed regressions are covered via new tests.
  • Any new or changed features are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .
  • If the changes affect any plotting functions you have checked that the plots
    from all the CI builds look correct. Add the "upload_plots" tag so that plotting
    outputs are attached as artifacts.
  • New modules, add the module to CODEOWNERS with your github handle
  • Add the ready for review tag when you are ready for the PR to be reviewed.

@megies megies added .clients.fdsn test_network tell github actions to also run network tests for this PR labels Feb 3, 2023
@megies megies added this to the 1.4.1 milestone Feb 3, 2023
@trichter
Copy link
Member

trichter commented Feb 4, 2023

Oh, we need to update all our *env.yml files in the .github folder to reflect the sqlalchemy version requirements. Maybe you could add the change directly in this branch.

@trichter
Copy link
Member

trichter commented Feb 6, 2023

Hm, wait a moment. In the network warnings test we have a seg fault and other network tests are still running.


clients/earthworm/__init__.py .                                          [  0%]
clients/earthworm/client.py ...                                          [  2%]
Fatal Python error: Segmentation fault

https://github.com/obspy/obspy/actions/runs/4102013963/jobs/7076368317

@trichter
Copy link
Member

trichter commented Feb 6, 2023

Hm, wait a moment. In the network warnings test we have a seg fault and other network tests are still running.

But on the other hand, it is not related to this PR.

@megies
Copy link
Member Author

megies commented Feb 9, 2023

Re-ran failed tests, segfault at least is gone. The rest is unrelated fails.

@megies megies merged commit c63c1a5 into maintenance_1.4.x Feb 9, 2023
@megies megies deleted the fdsn_raspi_url branch February 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.clients.fdsn test_network tell github actions to also run network tests for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants