Skip to content

Google News max result fix #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2021
Merged

Google News max result fix #211

merged 4 commits into from
Oct 26, 2021

Conversation

tanish36
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@tanish36 tanish36 mentioned this pull request Oct 16, 2021
Closed
@lalitpagaria
Copy link
Collaborator

@tanish36 Thank you for working on it.
I will review and share feedback

lalitpagaria
lalitpagaria reviewed Oct 17, 2021
View reviewed changes
lalitpagaria
lalitpagaria reviewed Oct 17, 2021
View reviewed changes
lalitpagaria
lalitpagaria requested changes Oct 17, 2021
View reviewed changes
Copy link
Collaborator

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanish36 I reviewed your changes added few comments. Please address them. Also if possible, please add test or test your change with example file https://github.com/obsei/obsei/blob/master/example/google_news_example.py (update the param accordingly)

@lalitpagaria
Copy link
Collaborator

@tanish36 I don't see changes. I think you might have miss added them.

Also I correcting my comment #211 (comment)
Correct code is this -

previous_articles_count = -1
while (len(source_responses) != previous_articles_count):
        previous_articles_count  = len(source_responses)

         if config.max_results is not None and len(source_responses) >= config.max_results:
                  break

@lalitpagaria lalitpagaria merged commit 66a406a into obsei:master Oct 26, 2021
@lalitpagaria
Copy link
Collaborator

@tanish36 I have updated the code and merged it.
Thank you for working on it.

@lalitpagaria lalitpagaria linked an issue Oct 27, 2021 that may be closed by this pull request
[BUG] Google News only return 100 query even if max_results is set at 1000 #208
Closed
@lalitpagaria lalitpagaria added this to the Release 0.0.11 milestone Oct 27, 2021
@lalitpagaria lalitpagaria added the bug Something isn't working label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitpagaria lalitpagaria lalitpagaria requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release 0.0.11
Development

Successfully merging this pull request may close these issues.

[BUG] Google News only return 100 query even if max_results is set at 1000
3 participants
@tanish36 @CLAassistant @lalitpagaria