Skip to content

Conversation

shahrukhx01
Copy link
Collaborator

The initial draft for text classifier which will resolve #77

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2021

CLA assistant check
All committers have signed the CLA.

@shahrukhx01
Copy link
Collaborator Author

@lalitpagaria PR is complete from my side, one possible improvement that can be added. is mapping of labels, transformers map labels as {"LABEL_0", "LABEL_1",....,"LABEL_N"}, what we can do is use the labels parameter and map values from labels to transformers labels, however, if the user passes the wrong sequence of labels, they'd get altogether wrong predictions. So there must be some mechanism for enforcing the right sequence in my knowledge it won't be possible to enforce such a check. what do you think?

@lalitpagaria
Copy link
Collaborator

lalitpagaria commented Sep 7, 2021

@shahrukhx01 I have refactored you changes a little. Also added functionality to support user provided label map. Check test and let me know if you have any concern. Post that I will merge this.
Also it would be great if we plan a demo/article/colab showing capabilities of https://huggingface.co/obsei-ai/sell-buy-intent-classifier-bert-mini

Or we can show demo of newly added classifier to detect hate speech via https://huggingface.co/Hate-speech-CNERG/dehatebert-mono-english
So workflow would be Twitter or Reddit -> Analyzer -> Elastic Search or Slack

WDYT?

Copy link
Collaborator

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalitpagaria lalitpagaria merged commit 4a85931 into master Sep 8, 2021
@lalitpagaria lalitpagaria deleted the add_text_classification_analyzer branch September 8, 2021 11:03
@shahrukhx01
Copy link
Collaborator Author

shahrukhx01 commented Sep 8, 2021

@lalitpagaria I can write a small collab tutorial using Obsei and then post-it on LinkedIn about the buy-sell intent model.

@lalitpagaria
Copy link
Collaborator

@lalitpagaria lalitpagaria added the enhancement New feature or request label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Analyzer] Integrate intent classifier
3 participants