Skip to content

Conversation

cnarte
Copy link
Contributor

@cnarte cnarte commented Aug 27, 2021

This fork helps to parse data from pandas dataframe or from user input of a csv file or excel sheets.
The input_type of target needs to be specified from this list. ["csv","dataframe","excel'].
Added example script too for testing purposes in example dir.
Resolves #169

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cnarte I have reviewed PR. Have comments please address them. Let's keep first thing simple.

@lalitpagaria
Copy link
Collaborator

Also check type check errors as well

@cnarte
Copy link
Contributor Author

cnarte commented Aug 28, 2021

Made changes as per recommended :

  • renamed pandas_scrapper ---> pandas_source_example
  • renamed pandas_source ---> pandas
  • Removed csv and excel code
  • Now df.apply is being used for parsing purpose as its based on cython and faster

@cnarte cnarte requested a review from lalitpagaria August 29, 2021 09:36
@lalitpagaria lalitpagaria merged commit 8373b01 into obsei:master Aug 30, 2021
@lalitpagaria lalitpagaria changed the title Pandas/CSV/TSV as Observer/Source supporting dataframe, CSV, and Excel Add Pandas as Observer/Source Aug 30, 2021
@lalitpagaria lalitpagaria added the enhancement New feature or request label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas as Observer/Source
3 participants