Skip to content

Added Facebook integration as source #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2021
Merged

Added Facebook integration as source #150

merged 4 commits into from
Jul 3, 2021

Conversation

GirishPatel
Copy link
Collaborator

For testing set following environment variables and run facebook_example.py

facebook_app_id={app_id}
facebook_app_secret={app_secret}
long_term_token={long_term_token}

@GirishPatel GirishPatel requested a review from lalitpagaria June 22, 2021 18:04
lalitpagaria
lalitpagaria reviewed Jun 22, 2021
View reviewed changes
lalitpagaria
lalitpagaria reviewed Jun 22, 2021
View reviewed changes
lalitpagaria
lalitpagaria reviewed Jun 22, 2021
View reviewed changes
@GirishPatel GirishPatel force-pushed the facebook-integration branch from 047a02b to cef2bb6 Compare June 22, 2021 18:40
lalitpagaria
lalitpagaria requested changes Jun 22, 2021
View reviewed changes
Copy link
Collaborator

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few comments rest are fine 👍🏼

@lalitpagaria
Copy link
Collaborator

lalitpagaria commented Jun 30, 2021 •
edited
Loading

@GirishPatel update PR and added state management and simplified facebook post data retriever.
Can you please poll change from this branch to your repo https://github.com/lalitpagaria/obsei/tree/pr/150
Can you please review

lalitpagaria
lalitpagaria approved these changes Jun 30, 2021
View reviewed changes
Copy link
Collaborator

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just check if nothing is broken with my changes. If possible state management changes.

@lalitpagaria lalitpagaria merged commit d428ce3 into obsei:master Jul 3, 2021
@lalitpagaria lalitpagaria linked an issue Jul 3, 2021 that may be closed by this pull request
Add Facebook Observer/Source #16
Closed
@lalitpagaria lalitpagaria mentioned this pull request Jul 3, 2021
Closed
@lalitpagaria lalitpagaria added the enhancement New feature or request label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitpagaria lalitpagaria lalitpagaria approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Facebook Observer/Source
2 participants
@GirishPatel @lalitpagaria