-
Notifications
You must be signed in to change notification settings - Fork 172
Pre commit integration #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre commit integration #156
Conversation
@salilmishra23 thank you very much for your PR. I will review it by tomorrow and share feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@salilmishra23 Thank you for working on it. I have reviewed your PR. It is looking nice I have few comments. Can you please address them
Also can you please add information about how to perform pre-commit check in contribution guideline
@lalitpagaria I have added the Does adding Anyways let me know what you think about this. I have no other problem if you want me to add |
@salilmishra23 You PR is complete functionality wise. Can you please add information about how to perform pre-commit check in contribution guideline. Post it I will approve and merge this PR. Okay let's skip pytest for now, we can later add when we feel a need for pytest in pre-commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@salilmishra23 Thank you for working on this.
For issue #132, added the following hooks:
We can add tests and mypy too as hooks but can keep that for another PR.
Let me know if you want to add/remove hooks.