feat: fork of bitnami redis chart 🛟 #330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45d89f6 to
ff26f6d
Compare
|
@tuunit, ping me on Slack when you need approval 🚀 |
78eb106 to
d0c4925
Compare
Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Jan Larwig <jan@larwig.com>
…per template files Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Jan Larwig <jan@larwig.com>
754afd3 to
30fb8c8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fork of the bitnami Redis Helm chart to replace proprietary Bitnami images with open-source alternatives. The fork aims to provide a drop-in replacement while maintaining compatibility with the original chart structure and functionality.
Key changes include:
- Replacement of Bitnami-specific container images with open-source alternatives
- Complete Helm chart template structure for Redis deployment with Sentinel support
- Comprehensive service configurations including external access and monitoring
Comments suppressed due to low confidence (2)
helm/redis/templates/scripts-configmap.yaml:124
- The script path references '/opt/bitnami/scripts/' which may not exist in non-Bitnami container images. This should be verified to match the actual paths in the replacement images.
[[ -f $REDIS_MASTER_PASSWORD_FILE ]] && export REDIS_MASTER_PASSWORD="$(< "${REDIS_MASTER_PASSWORD_FILE}")"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
|
Closed in favour of #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the initial release of a forked Redis Helm chart under the OAuth2-Proxy organization. The main focus is on rebranding the chart, updating image sources, cleaning up metadata, and removing Bitnami-specific dependencies and references. The most important changes are summarized below:
Chart Rebranding and Metadata Updates:
Chart.yaml, including maintainers, sources, home, and annotations. Updated the chart version to22.0.0and added a changelog annotation for the fork.LICENSE.mdfile with Apache 2.0 license and Broadcom copyright.Dependency and File Cleanup:
commonchart dependency by deletingChart.lockand cleaning upChart.yaml..helmignorefile to exclude unnecessary files and directories from chart packaging.Image Source and Configuration Changes:
values.yamlto use upstream/community images (e.g.,redis,oliver006/redis_exporter,debian,rancher/kubectl) instead of Bitnami images.Chart Testing Configuration:
ct.yamlto disable maintainer validation and remove commented-out extra args, aligning with the new maintainership.Sources
Redis Exporter Image from Bitnami is just a wrapper around:
https://hub.docker.com/r/oliver006/redis_exporter
https://github.com/oliver006/redis_exporter
https://github.com/bitnami/containers/tree/main/bitnami/redis-exporter
os-shell is just debian
https://github.com/bitnami/containers/tree/main/bitnami/os-shell
kubectl image from suse rancher:
https://hub.docker.com/r/rancher/kubectl/tags?name=1.33.3
Todo