fix: connection urls to be automatically comma separated #268

tuunit · 2024-11-27T17:54:45Z

Description

The connectionUrls attribute of sessionStorage.redis.cluster and sessionStorage.redis.sentinel is currently of type array which doesn't work.

Solution

Add join "," to the templating to automatically generate a comma separated string and allow for single string values as well.

tuunit · 2024-11-27T17:57:57Z

@pierluigilenoci I think the new test case is broken. Will quickly check tomorrow. I have a bad connection right now and cannot fetch the redis helm chart -.-

pierluigilenoci · 2024-11-28T13:21:15Z

@tuunit, this is a breaking change.
The version bump must be a major version and a migration guide must be added.

tuunit · 2024-11-28T14:35:55Z

@tuunit, this is a breaking change. The version bump must be a major version and a migration guide must be added.

This is not a breaking change!!

pierluigilenoci · 2024-12-23T09:30:15Z

@tuunit, do you have any chances to move forward with this?

tuunit · 2025-02-06T12:17:58Z

@pierluigilenoci please have another review of this PR :)

I added two test cases to demonstrate that it is not a breaking change

helm/oauth2-proxy/ci/redis-sentinel-comma-values.yaml

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [oauth2-proxy](https://oauth2-proxy.github.io/oauth2-proxy/) ([source](https://github.com/oauth2-proxy/manifests)) | minor | `7.7.31` -> `7.12.18` | --- ### Release Notes <details> <summary>oauth2-proxy/manifests (oauth2-proxy)</summary> ### [`v7.12.18`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.18) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.17...oauth2-proxy-7.12.18) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - sessionStorage.type: Redis -> redis by [@fabiant7t](https://github.com/fabiant7t) in oauth2-proxy/manifests#315 - chore(deps): update helm release redis to v21.2.3 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#316 #### New Contributors - [@fabiant7t](https://github.com/fabiant7t) made their first contribution in oauth2-proxy/manifests#315 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.17...oauth2-proxy-7.12.18 ### [`v7.12.17`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.17) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.16...oauth2-proxy-7.12.17) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v21.1.7 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#313 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.16...oauth2-proxy-7.12.17 ### [`v7.12.16`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.16) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.15...oauth2-proxy-7.12.16) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - fix: rendering of nodeSelector without whitespace by [@jess-belliveau](https://github.com/jess-belliveau) in oauth2-proxy/manifests#305 #### New Contributors - [@jess-belliveau](https://github.com/jess-belliveau) made their first contribution in oauth2-proxy/manifests#305 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.15...oauth2-proxy-7.12.16 ### [`v7.12.15`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.15) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.14...oauth2-proxy-7.12.15) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v21.1.6 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#312 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.14...oauth2-proxy-7.12.15 ### [`v7.12.14`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.14) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.13...oauth2-proxy-7.12.14) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v21.1.5 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#310 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.13...oauth2-proxy-7.12.14 ### [`v7.12.13`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.13) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.12...oauth2-proxy-7.12.13) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v21 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#308 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.12...oauth2-proxy-7.12.13 ### [`v7.12.12`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.12) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.11...oauth2-proxy-7.12.12) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.13.4 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#306 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.11...oauth2-proxy-7.12.12 ### [`v7.12.11`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.11) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.10...oauth2-proxy-7.12.11) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore: update oauth2-proxy to v7.9.0 by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#304 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.10...oauth2-proxy-7.12.11 ### [`v7.12.10`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.10) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.9...oauth2-proxy-7.12.10) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.13.3 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#303 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.9...oauth2-proxy-7.12.10 ### [`v7.12.9`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.9) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.8...oauth2-proxy-7.12.9) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.11.5 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#300 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.8...oauth2-proxy-7.12.9 ### [`v7.12.8`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.8) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.7...oauth2-proxy-7.12.8) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore: bump oauth2-proxy appVersion to v7.8.2 by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#298 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.7...oauth2-proxy-7.12.8 ### [`v7.12.7`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.7) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.6...oauth2-proxy-7.12.7) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update dependency python to 3.13 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#297 - chore(deps): update helm release redis to v20.11.4 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#296 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.6...oauth2-proxy-7.12.7 ### [`v7.12.6`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.6) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.5...oauth2-proxy-7.12.6) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.11.3 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#294 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.5...oauth2-proxy-7.12.6 ### [`v7.12.5`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.5) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.4...oauth2-proxy-7.12.5) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.11.2 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#293 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.4...oauth2-proxy-7.12.5 ### [`v7.12.4`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.4) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.3...oauth2-proxy-7.12.4) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.11.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#292 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.3...oauth2-proxy-7.12.4 ### [`v7.12.3`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.3) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.2...oauth2-proxy-7.12.3) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.10.1 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#291 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.2...oauth2-proxy-7.12.3 ### [`v7.12.2`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.2) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.1...oauth2-proxy-7.12.2) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.10.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#290 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.1...oauth2-proxy-7.12.2 ### [`v7.12.1`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.1) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.12.0...oauth2-proxy-7.12.1) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.9.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#289 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.12.0...oauth2-proxy-7.12.1 ### [`v7.12.0`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.12.0) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.11.2...oauth2-proxy-7.12.0) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - Add extraInitContainer option by [@pratiyushpushkar05](https://github.com/pratiyushpushkar05) in oauth2-proxy/manifests#288 #### New Contributors - [@pratiyushpushkar05](https://github.com/pratiyushpushkar05) made their first contribution in oauth2-proxy/manifests#288 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.11.2...oauth2-proxy-7.12.0 ### [`v7.11.2`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.11.2) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.11.1...oauth2-proxy-7.11.2) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.8.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#287 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.11.1...oauth2-proxy-7.11.2 ### [`v7.11.1`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.11.1) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.11.0...oauth2-proxy-7.11.1) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.7.1 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#285 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.11.0...oauth2-proxy-7.11.1 ### [`v7.11.0`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.11.0) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.5...oauth2-proxy-7.11.0) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - Make deploy.enableServiceLinks configurable by [@jkroepke](https://github.com/jkroepke) in oauth2-proxy/manifests#284 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.5...oauth2-proxy-7.11.0 ### [`v7.10.5`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.5) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.4...oauth2-proxy-7.10.5) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - doc: improved the documentation in values.yaml for Redis password by [@max-pfeiffer](https://github.com/max-pfeiffer) in oauth2-proxy/manifests#283 #### New Contributors - [@max-pfeiffer](https://github.com/max-pfeiffer) made their first contribution in oauth2-proxy/manifests#283 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.4...oauth2-proxy-7.10.5 ### [`v7.10.4`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.4) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.3...oauth2-proxy-7.10.4) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - doc(maintainers): update maintainers in Chart.yaml by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#282 - fix: connection urls to be automatically comma separated by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#268 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.3...oauth2-proxy-7.10.4 ### [`v7.10.3`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.3) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.2...oauth2-proxy-7.10.3) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm/chart-releaser-action action to v1.7.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#280 - chore(deps): update helm release redis to v20.7.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#281 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.2...oauth2-proxy-7.10.3 ### [`v7.10.2`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.2) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.1...oauth2-proxy-7.10.2) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.6.3 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#279 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.1...oauth2-proxy-7.10.2 ### [`v7.10.1`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.1) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.10.0...oauth2-proxy-7.10.1) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - doc: update maintainers / owners by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#277 - chore: bump to v7.8.1 by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#278 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.10.0...oauth2-proxy-7.10.1 ### [`v7.10.0`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.10.0) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.9.2...oauth2-proxy-7.10.0) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore: update oauth2-proxy to v7.8.0 by [@air3ijai](https://github.com/air3ijai) in oauth2-proxy/manifests#276 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.9.2...oauth2-proxy-7.10.0 ### [`v7.9.2`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.9.2) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.9.1...oauth2-proxy-7.9.2) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.6.2 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#275 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.9.1...oauth2-proxy-7.9.2 ### [`v7.9.1`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.9.1) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.9.0...oauth2-proxy-7.9.1) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - Fixed incorrect helm template syntax in README.md by [@kaushall](https://github.com/kaushall) in oauth2-proxy/manifests#274 #### New Contributors - [@kaushall](https://github.com/kaushall) made their first contribution in oauth2-proxy/manifests#274 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.9.0...oauth2-proxy-7.9.1 ### [`v7.9.0`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.9.0) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.8.3...oauth2-proxy-7.9.0) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - feat: add possibility to route requests to sidecar container by [@edorizzardi](https://github.com/edorizzardi) in oauth2-proxy/manifests#270 #### New Contributors - [@edorizzardi](https://github.com/edorizzardi) made their first contribution in oauth2-proxy/manifests#270 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.8.3...oauth2-proxy-7.9.0 ### [`v7.8.3`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.8.3) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.8.2...oauth2-proxy-7.8.3) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.6.1 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#273 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.8.2...oauth2-proxy-7.8.3 ### [`v7.8.2`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.8.2) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.8.1...oauth2-proxy-7.8.2) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(deps): update helm release redis to v20.5.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#271 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.8.1...oauth2-proxy-7.8.2 ### [`v7.8.1`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.8.1) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.8.0...oauth2-proxy-7.8.1) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - chore(feat): Added renovate by [@pierluigilenoci](https://github.com/pierluigilenoci) in oauth2-proxy/manifests#257 - chore(config): migrate renovate config by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#261 - chore(deps): update helm/chart-releaser-action action to v1.6.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#262 - chore(deps): update all-major-updates (major) by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#263 - doc: add contribution guide by [@tuunit](https://github.com/tuunit) in oauth2-proxy/manifests#264 - chore(deps): update helm release redis to v20.4.0 by [@renovate](https://github.com/renovate) in oauth2-proxy/manifests#269 #### New Contributors - [@renovate](https://github.com/renovate) made their first contribution in oauth2-proxy/manifests#261 - [@tuunit](https://github.com/tuunit) made their first contribution in oauth2-proxy/manifests#264 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.8.0...oauth2-proxy-7.8.1 ### [`v7.8.0`](https://github.com/oauth2-proxy/manifests/releases/tag/oauth2-proxy-7.8.0) [Compare Source](oauth2-proxy/manifests@oauth2-proxy-7.7.31...oauth2-proxy-7.8.0) A reverse proxy that provides authentication with Google, Github or other providers #### What's Changed - feat: allow templates in annotations by [@gtudan](https://github.com/gtudan) in oauth2-proxy/manifests#256 #### New Contributors - [@gtudan](https://github.com/gtudan) made their first contribution in oauth2-proxy/manifests#256 **Full Changelog**: oauth2-proxy/manifests@oauth2-proxy-7.7.31...oauth2-proxy-7.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate-test@test.local> Reviewed-on: https://gitea.v2.zarek.cc/twinlabs/argocd/pulls/28 Co-authored-by: bot <bot@example.com> Co-committed-by: bot <bot@example.com>

tuunit mentioned this pull request Nov 27, 2024

sessionStorage.redis.sentinel.connectionUrls creates array, but expects string #267

Closed

tuunit force-pushed the fix-connection-urls-syntax branch from 4ce8e98 to cb59386 Compare November 27, 2024 18:01

tuunit force-pushed the fix-connection-urls-syntax branch 4 times, most recently from 0a6c1a0 to adf5843 Compare November 28, 2024 14:47

pierluigilenoci previously approved these changes Jan 2, 2025

View reviewed changes

pierluigilenoci dismissed their stale review via 4be2f1b January 8, 2025 09:54

pierluigilenoci previously approved these changes Jan 8, 2025

View reviewed changes

pierluigilenoci dismissed their stale review via 073880f January 8, 2025 10:18

tuunit force-pushed the fix-connection-urls-syntax branch 2 times, most recently from 3ec10b4 to 733f0e2 Compare January 18, 2025 16:31

tuunit force-pushed the fix-connection-urls-syntax branch 3 times, most recently from c257579 to 1d3cd8d Compare February 6, 2025 12:10

fix: connection urls to be automatically comma separated

9d212ce

tuunit force-pushed the fix-connection-urls-syntax branch from 1d3cd8d to 9d212ce Compare February 6, 2025 12:18

pierluigilenoci reviewed Feb 6, 2025

View reviewed changes

helm/oauth2-proxy/ci/redis-sentinel-comma-values.yaml Show resolved Hide resolved

pierluigilenoci approved these changes Feb 6, 2025

View reviewed changes

tuunit merged commit 2e4cf2f into main Feb 6, 2025
1 check passed

tuunit deleted the fix-connection-urls-syntax branch February 6, 2025 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: connection urls to be automatically comma separated #268

fix: connection urls to be automatically comma separated #268

Uh oh!

tuunit commented Nov 27, 2024

Uh oh!

tuunit commented Nov 27, 2024

Uh oh!

pierluigilenoci commented Nov 28, 2024

Uh oh!

tuunit commented Nov 28, 2024

Uh oh!

pierluigilenoci commented Dec 23, 2024

Uh oh!

tuunit commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: connection urls to be automatically comma separated #268

fix: connection urls to be automatically comma separated #268

Uh oh!

Conversation

tuunit commented Nov 27, 2024

Description

Solution

Uh oh!

tuunit commented Nov 27, 2024

Uh oh!

pierluigilenoci commented Nov 28, 2024

Uh oh!

tuunit commented Nov 28, 2024

Uh oh!

pierluigilenoci commented Dec 23, 2024

Uh oh!

tuunit commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!