Skip to content

Fix lychee upgrade issue (lycheeignore upgrade) #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 19, 2025
Merged

Fix lychee upgrade issue (lycheeignore upgrade) #4964

merged 8 commits into from
Mar 19, 2025

Conversation

wesley-dean
Copy link
Contributor

The makeapullrequest.com URL found in README.md associated with the PRs Welcome badge is no longer working. This updates the .lycheeignore to not fail on that.
Fixes #4963

Proposed Changes

  1. update the root .lycheeignore to ignore makeapullrequest.com
  2. update the mega-linter-runner .lycheeignore to in sync with the root version
  3. updated reference link in .lycheeignore
  4. convert existing links into proper regular expressions
  5. change the broken "PRs Welcome" badge in the README.md to point to the contributing documentation

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance
    update

@wesley-dean wesley-dean mentioned this pull request Mar 19, 2025
Closed
@echoix
Copy link
Collaborator

echoix commented Mar 19, 2025

The website was https://web.archive.org/web/20250306034535/https://makeapullrequest.com/

It isn't as useful. Either we remove the badge, or replace with another URL? Like our contributing docs, the PR page? One of the links of the page?

@nvuillam nvuillam changed the title Merge pull request #1 from oxsecurity/main Fix lychee upgrade issue (lycheeignore upgrade) Mar 19, 2025
nvuillam
nvuillam approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @wesley-dean :)

@nvuillam nvuillam merged commit 6545bb4 into oxsecurity:main Mar 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

@echoix echoix Awaiting requested review from echoix echoix is a code owner

@bdovaz bdovaz Awaiting requested review from bdovaz bdovaz is a code owner

@Kurt-von-Laven Kurt-von-Laven Awaiting requested review from Kurt-von-Laven Kurt-von-Laven is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lychee is failing checks for http://makeapullrequest.com/ which is breaking MegaLinter runs
3 participants
@wesley-dean @echoix @nvuillam