Skip to content

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Feb 9, 2025

Try to fix #4662 problems by removing apk pinning

Copy link
Contributor

github-actions bot commented Feb 9, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 1 0 1.73s
⚠️ BASH bash-exec 6 1 0.02s
✅ BASH shellcheck 6 0 0.14s
✅ BASH shfmt 6 0 0 0.65s
✅ COPYPASTE jscpd yes no 2.85s
✅ DOCKERFILE hadolint 129 0 28.63s
✅ JSON jsonlint 20 0 0.28s
✅ JSON v8r 22 0 14.67s
⚠️ MARKDOWN markdownlint 267 0 303 22.2s
✅ MARKDOWN markdown-table-formatter 267 0 0 189.15s
⚠️ PYTHON bandit 214 66 3.97s
✅ PYTHON black 214 0 0 5.02s
✅ PYTHON flake8 214 0 2.09s
✅ PYTHON isort 214 0 0 1.19s
✅ PYTHON mypy 214 0 12.74s
✅ PYTHON pylint 214 0 32.5s
✅ PYTHON ruff 214 0 0 0.73s
✅ REPOSITORY checkov yes no 35.1s
✅ REPOSITORY git_diff yes no 0.45s
⚠️ REPOSITORY grype yes 24 13.66s
✅ REPOSITORY secretlint yes no 13.85s
✅ REPOSITORY trivy yes no 17.02s
✅ REPOSITORY trivy-sbom yes no 0.62s
⚠️ REPOSITORY trufflehog yes 1 56.36s
✅ SPELL cspell 717 0 11.77s
⚠️ SPELL lychee 349 28 26.32s
✅ XML xmllint 3 0 0 0.98s
✅ YAML prettier 160 0 0 3.96s
✅ YAML v8r 102 0 14.1s
✅ YAML yamllint 161 0 3.04s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 9, 2025

Ready @nvuillam @echoix!

What I have done with the original PR that was reverted:

  • Remove the APK pins, as we commented, in each alpine version there is only one version of each package so it loses the sense of pinning.
  • Fix from @echoix's fork the problem with Renovate.

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 9, 2025

Ready to merge @nvuillam @echoix

@echoix
Copy link
Collaborator

echoix commented Feb 9, 2025

Did you try it on your main fork too?

@echoix
Copy link
Collaborator

echoix commented Feb 9, 2025

Merge when you're available to monitor right after

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 9, 2025

Did you try it on your main fork too?

I had understood that your fork was already fine and that I could copy it as is.

@echoix
Copy link
Collaborator

echoix commented Feb 9, 2025

The renovate config file change, I did try.

I meant if you wanted to try it on your fork, merging in your main before, or you're confident enough to try it in the main here

@echoix
Copy link
Collaborator

echoix commented Feb 9, 2025

Now there's conflicts because other PRs were just merged

@bdovaz
Copy link
Collaborator Author

bdovaz commented Feb 9, 2025

The renovate config file change, I did try.

I meant if you wanted to try it on your fork, merging in your main before, or you're confident enough to try it in the main here

I just tested it locally and it works correctly against constants.py script. In the following screenshot you can see how it finds pip package update:

image

Now there's conflicts because other PRs were just merged

Fixed!

@bdovaz bdovaz merged commit 1076931 into main Feb 10, 2025
130 checks passed
@bdovaz bdovaz deleted the renovate-packages branch February 10, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants