Skip to content

Handle panic when parsing literal #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

Handle panic when parsing literal #557

merged 1 commit into from
Jun 2, 2025

Conversation

jeffcharles
Copy link
Contributor

I've noticed an error about a literal not fitting in a type in a build of mine. The error message is from here and looks like:

thread 'main' panicked at C:\Users\runneradmin.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\rb-sys-build-0.9.115\src\bindings.rs:244:44:
called Result::unwrap() on an Err value: Error("number too large to fit in target type")

Defaulting to 1 seems sane given we want to coerce a value to a boolean.

ianks
ianks approved these changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@ianks ianks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@ianks ianks merged commit 87e5343 into oxidize-rb:main Jun 2, 2025
43 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianks ianks ianks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @ianks