Bump rake-compiler-dock images to v1.8.0 with Ruby patch versions #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects the changes made in rake-compiler/rake-compiler-dock#135. While this requires packages to update their `RUBY_CC_VERSION` to use Ruby patches across the board, this is already needed for Ruby 3.3.5. This change at least makes this consistent. See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0.
9a4ae8c to
9ae34b0
Compare
|
Thank you so much! Running a build to check that it works, then will merge ❤️ https://github.com/oxidize-rb/rb-sys/actions/runs/12814269578 |
|
Ahh, forgot that we need to make rb-sys-dock aware of the patch versions. Can you add them here? (also, it's a little janky since we have to define the same string everywhere, open to ideas for improving as well) |
|
Yes, I'll add them now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects the changes made in rake-compiler/rake-compiler-dock#135.
While this requires packages to update their
RUBY_CC_VERSIONto use Ruby patches across the board, this is already needed for Ruby 3.3.5. This change at least makes this consistent.See https://github.com/rake-compiler/rake-compiler-dock/releases/tag/v1.8.0.