Add stable API for Ruby 3.4 #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianks
commented
Nov 21, 2024
| @@ -141,6 +142,9 @@ pub unsafe fn setup_ruby_unguarded() { | |||
| rb_sys::rb_w32_sysinit(&mut argc, &mut argv); | |||
| } | |||
|
|
|||
| let mut stack_marker: VALUE = 0; | |||
| ruby_init_stack(addr_of_mut!(stack_marker) as *mut _); | |||
There was a problem hiding this comment.
This was causing GC issues in Ruby 3.4, due to Ruby being unable to mark objects on the machine stack. Not sure why this wasn't an issue before, but now it's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a stable API implementation for Ruby 3.4. It is exactly the same as Ruby 3.3, since there were not incompatible changes in this release cycle for the methods we support.