Skip to content

Update sccache from v0.3.3 to v0.9.1 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update sccache from v0.3.3 to v0.9.1 #52

merged 1 commit into from
Jan 21, 2025

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Jan 21, 2025 •
edited
Loading

This resolves the OpenSSL 1.1 dependency issue: oxidize-rb/rb-sys#497

@gjtorikian
Copy link
Collaborator

LGTM but

This might resolve

Are you able to point your CI action to this ref and see if it resolves the issue? I'm wary about that "might," although in general I agree this dependency should probably be bumped regardless.

@stanhu stanhu mentioned this pull request Jan 21, 2025
Closed
@stanhu
Copy link
Contributor Author

stanhu commented Jan 21, 2025 •
edited
Loading

@gjtorikian I attempted to point it to this ref in https://github.com/oxidize-rb/rb-sys/actions/runs/12877578630/job/35902248995?pr=496, but unfortunately that doesn't work because this repo calls cargo-binstall with. the version here:

Run oxidize-rb/actions/cargo-binstall@v1
  with:
    crate: sccache
    version: 0.3.3
    strategies: quick-install
    install-path: /home/runner/work/_actions/oxidize-rb/actions/v1/setup-ruby-and-rust/bin

I'd need to make another change here to change cargo-binstall to point to this ref, and then point the other repo to that change. 😄

Never mind, updated in oxidize-rb/rb-sys#498.

@stanhu stanhu force-pushed the sh-update-sccache branch from 6c7133f to 039a655 Compare January 21, 2025 19:00
@stanhu
Copy link
Contributor Author

stanhu commented Jan 21, 2025 •
edited
Loading

Yeah, https://github.com/oxidize-rb/rb-sys/actions/runs/12894027138/job/35951762057?pr=498 seems to have passed now with this change:


   INFO resolve: Verified signature for package 'sccache-0.9.1-x86_64-unknown-linux-gnu': timestamp:1736256999	file:sccache-0.9.1-x86_64-unknown-linux-gnu.tar.gz	hashed
   WARN resolve: When resolving sccache bin sccache-dist is not found. But since it requies features dist-server, this bin is ignored.
   WARN The package sccache v0.9.1 (x86_64-unknown-linux-gnu) has been downloaded from third-party source QuickInstall
   INFO This will install the following binaries:
   INFO   - sccache (sccache -> /home/runner/work/_actions/oxidize-rb/actions/50c22e098940b3e773ee8bbc1be80beba580a3c3/setup-ruby-and-rust/bin/sccache)
   INFO Installing binaries...

@stanhu stanhu mentioned this pull request Jan 21, 2025
Closed
@stanhu stanhu force-pushed the sh-update-sccache branch from 039a655 to 50c22e0 Compare January 21, 2025 19:10
@stanhu
Update sccache from v0.3.3 to v0.9.1
3a41198 
This resolves the OpenSSL 1.1 dependency issue:
oxidize-rb/rb-sys#497
@stanhu stanhu force-pushed the sh-update-sccache branch from 50c22e0 to 3a41198 Compare January 21, 2025 19:11
@gjtorikian gjtorikian merged commit 841a470 into oxidize-rb:main Jan 21, 2025
@gjtorikian
Copy link
Collaborator

tysm!

@stanhu stanhu mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanhu @gjtorikian