Skip to content

refactor(traverse): add TraverseCtx::insert_scope_below_statements #9757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

refactor(traverse): add TraverseCtx::insert_scope_below_statements #9757

merged 1 commit into from
Mar 13, 2025

Conversation

overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 13, 2025 •
edited
Loading

Follow-on after #9748. Our convention is to add aliases for all methods on TraverseScoping to TraverseCtx too, to make usage shorter.

Add an alias for insert_scope_below_statements, added in #9748.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 13, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 13, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Mar 13, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 13, 2025 14:07
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 13, 2025 14:07
@overlookmotel overlookmotel requested review from camc314 and removed request for Dunqing March 13, 2025 14:08
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9757 will create unknown performance changes

Comparing 03-13-refactor_traverse_add_traversectx_insert_scope_below_statements_ (bda4b9a) with main (d7dda5c)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 59 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 294.4 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
🆕 minifier[antd.js] N/A 167.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 294.6 ms N/A
🆕 estree[checker.ts] N/A 88.4 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 89.7 µs N/A
🆕 parser[antd.js] N/A 112 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel mentioned this pull request Mar 13, 2025
Merged
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 13, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 13, 10:16 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 13, 10:16 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 13, 10:24 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
refactor(traverse): add TraverseCtx::insert_scope_below_statements (#…
bda4b9a 
…9757)

Follow-on after #9748. Our convention is to add aliases for all methods on `TraverseScoping` to `TraverseCtx` too, to make usage shorter.

Add an alias for `insert_scope_below_statements`, added in #9748.
@graphite-app graphite-app bot force-pushed the 03-13-refactor_traverse_add_doc_comment_for_traversescoping_insert_scope_below_statements_and_rename_var branch from 9802058 to d7dda5c Compare March 13, 2025 14:17
@graphite-app graphite-app bot force-pushed the 03-13-refactor_traverse_add_traversectx_insert_scope_below_statements_ branch from acd9d10 to bda4b9a Compare March 13, 2025 14:18
Base automatically changed from 03-13-refactor_traverse_add_doc_comment_for_traversescoping_insert_scope_below_statements_and_rename_var to main March 13, 2025 14:22
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@graphite-app graphite-app bot merged commit bda4b9a into main Mar 13, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 03-13-refactor_traverse_add_traversectx_insert_scope_below_statements_ branch March 13, 2025 14:24
@oxc-bot oxc-bot mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @camc314