test(transformer/using): failing test for class name #9678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2025
This was referenced Mar 11, 2025
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
approved these changes
Mar 11, 2025
890413f to
9743ebb
Compare
24ebeb0 to
e136646
Compare
Merge activity
|
9743ebb to
acac461
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Add a failing test for `using` transform where exported class has a reference to itself within the class body, and the external class binding is mutated. This is something of an edge case, but it'd be ideal to handle it correctly. Babel has the same bug: babel/babel#17172
e136646 to
4cee555
Compare
Reading the code. But I'm familiar with these edge cases from working on the class properties transform. We've found during past months on transformer that Babel's test cases often don't cover as much as you'd like. Sometimes there are bugs in edge cases which are rare in practice, so no-one has noticed. But also some things are really simple to do in JS, so Babel probably didn't see the need to add tests for things which are obvious - but they're not nearly as simple or obvious in Rust. So we've had to add quite a lot of extra tests on some transforms. |
acac461 to
26499ec
Compare
4cee555 to
76df73e
Compare
Add a failing test for `using` transform where exported class has a reference to itself within the class body, and the external class binding is mutated. This is something of an edge case, but it'd be ideal to handle it correctly. Babel has the same bug: babel/babel#17172
26499ec to
664c6f8
Compare
76df73e to
4dc32db
Compare
Base automatically changed from
03-11-refactor_transformer_using_rename_vars
to
main
March 11, 2025 12:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a failing test for
usingtransform where exported class has a reference to itself within the class body, and the external class binding is mutated.This is something of an edge case, but it'd be ideal to handle it correctly.
Babel has the same bug: babel/babel#17172