Skip to content

refactor(transformer/using): rename vars #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

refactor(transformer/using): rename vars #9677

merged 1 commit into from
Mar 11, 2025

Conversation

overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 11, 2025 •
edited
Loading

Follow-on after #9310. Pure refactor. Just rename vars to be more descriptively named, rather than generic names like node.

This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 11, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9677 will create unknown performance changes

Comparing 03-11-refactor_transformer_using_rename_vars (664c6f8) with main (15dd0d4)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 4.9 ms N/A
🆕 parser_napi[pdf.mjs] N/A 1.8 s N/A
🆕 parser_napi_raw[RadixUIAdoptionSection.jsx] N/A 1.3 ms N/A
🆕 parser_napi_raw[cal.com.tsx] N/A 700.2 ms N/A
🆕 parser_napi_raw[checker.ts] N/A 1.1 s N/A
🆕 parser_napi_raw[pdf.mjs] N/A 266.6 ms N/A
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.1 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 294.7 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@overlookmotel overlookmotel marked this pull request as ready for review March 11, 2025 06:57
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 11, 2025 06:57
@overlookmotel overlookmotel requested review from camc314 and removed request for Dunqing March 11, 2025 06:57
@overlookmotel
Copy link
Member Author

@camc314 Sorry for the litany of small changes. I've split it up into multiple PRs so you can follow what I've done, and the rationale for the changes.

This was referenced Mar 11, 2025
Merged
Merged
@camc314 Graphite App
Copy link
Contributor

camc314 commented Mar 11, 2025

these PRs are great, very easy to review 🙂
i added merge for the first one, but the rest has @Dunqing as a reviewer? so will leave to you to hit the button!

@camc314 camc314 force-pushed the 03-11-perf_transformer_using_avoid_large_types_on_stack branch from 8d255b1 to 2043688 Compare March 11, 2025 09:45
@camc314 camc314 force-pushed the 03-11-refactor_transformer_using_rename_vars branch from 890413f to 9743ebb Compare March 11, 2025 09:45
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Mar 11, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 03-11-perf_transformer_using_avoid_large_types_on_stack branch from 2043688 to d06e5f2 Compare March 11, 2025 10:15
graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
@overlookmotel
refactor(transformer/using): rename vars (#9677)
acac461 
Follow-on after #9310. Pure refactor. Just rename vars to be more descriptively named, rather than generic names like `node`.
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_rename_vars branch from 9743ebb to acac461 Compare March 11, 2025 10:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app graphite-app bot force-pushed the 03-11-perf_transformer_using_avoid_large_types_on_stack branch from d06e5f2 to 36aa13d Compare March 11, 2025 10:43
graphite-app bot pushed a commit that referenced this pull request Mar 11, 2025
@overlookmotel
refactor(transformer/using): rename vars (#9677)
26499ec 
Follow-on after #9310. Pure refactor. Just rename vars to be more descriptively named, rather than generic names like `node`.
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_rename_vars branch from acac461 to 26499ec Compare March 11, 2025 10:43
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@overlookmotel
refactor(transformer/using): rename vars (#9677)
664c6f8 
Follow-on after #9310. Pure refactor. Just rename vars to be more descriptively named, rather than generic names like `node`.
@graphite-app graphite-app bot force-pushed the 03-11-perf_transformer_using_avoid_large_types_on_stack branch from 36aa13d to 15dd0d4 Compare March 11, 2025 12:13
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_rename_vars branch from 26499ec to 664c6f8 Compare March 11, 2025 12:13
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
Base automatically changed from 03-11-perf_transformer_using_avoid_large_types_on_stack to main March 11, 2025 12:30
@graphite-app graphite-app bot merged commit 664c6f8 into main Mar 11, 2025
33 checks passed
@graphite-app graphite-app bot deleted the 03-11-refactor_transformer_using_rename_vars branch March 11, 2025 12:36
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @camc314