refactor(transformer/using): shorten AstBuilder calls
#9674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 11, 2025
CodSpeed Performance ReportMerging #9674 will not alter performanceComparing Summary
|
camc314
approved these changes
Mar 11, 2025
7fa8f6b to
cd610fa
Compare
ccde3da to
fc25c3b
Compare
Merge activity
|
cd610fa to
06bd816
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Follow-on after #9310. Pure refactor. Use shorter `AstBuilder` calls where possible. It's always preferable to use the `alloc_*` methods where possible, as it maximizes the chances compiler can see it can construct nodes directly in arena, rather than construct on stack and then copy to arena.
fc25c3b to
86ff47a
Compare
Base automatically changed from
03-11-refactor_transformer_using_add_more_comments_and_amend_some
to
main
March 11, 2025 10:10
Follow-on after #9310. Pure refactor. Use shorter `AstBuilder` calls where possible. It's always preferable to use the `alloc_*` methods where possible, as it maximizes the chances compiler can see it can construct nodes directly in arena, rather than construct on stack and then copy to arena.
86ff47a to
3180c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on after #9310. Pure refactor. Use shorter
AstBuildercalls where possible.It's always preferable to use the
alloc_*methods where possible, as it maximizes the chances compiler can see it can construct nodes directly in arena, rather than construct on stack and then copy to arena.