Skip to content

refactor(transformer/using): re-order imports #9672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

refactor(transformer/using): re-order imports #9672

merged 1 commit into from
Mar 11, 2025

Conversation

overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 11, 2025 •
edited
Loading

Follow-on after #9310. Style nit. Re-order imports with external crates before oxc_* crates.

This is just my personal OCD preference! I find it easier to see where imports are coming from when ordered like this. Sadly there is no rustfmt rule to enforce this style.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 11, 2025
@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 11, 2025
This was referenced Mar 11, 2025
Merged
Merged
Merged
Merged
@overlookmotel overlookmotel marked this pull request as ready for review March 11, 2025 06:42
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 11, 2025 06:42
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9672 will not alter performance

Comparing 03-11-refactor_transformer_using_re-order_imports (ce810ae) with main (75d33e8)

Summary

✅ 39 untouched benchmarks

@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@overlookmotel overlookmotel requested review from camc314 and removed request for Dunqing March 11, 2025 07:08
@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025 — with Graphite App
@camc314 Graphite App
Copy link
Contributor

camc314 commented Mar 11, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 11, 5:37 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 11, 5:37 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 11, 5:43 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
refactor(transformer/using): re-order imports (#9672)
ce810ae 
Follow-on after #9310. Style nit. Re-order imports with external crates before `oxc_*` crates.

This is just my personal OCD preference! I find it easier to see where imports are coming from when ordered like this. Sadly there is no rustfmt rule to enforce this style.
@graphite-app graphite-app bot force-pushed the 03-11-refactor_transformer_using_re-order_imports branch from 12a49cc to ce810ae Compare March 11, 2025 09:38
@graphite-app graphite-app bot merged commit ce810ae into main Mar 11, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 03-11-refactor_transformer_using_re-order_imports branch March 11, 2025 09:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 Awaiting requested review from camc314

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overlookmotel @camc314