Skip to content

feat(minifier): compress a != null ? a : b into a ?? b #8801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat(minifier): compress a != null ? a : b into a ?? b #8801

merged 1 commit into from
Jan 31, 2025

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 31, 2025 •
edited
Loading

It seems this was implemented in past by #8352 and was reverted in #8411. I'm not sure what was buggy, but one difference with this PR is that the previous PR doesn't check whether the identifier is a global reference or not.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jan 31, 2025
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Jan 31, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red mentioned this pull request Jan 31, 2025
Merged
@sapphi-red sapphi-red force-pushed the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch from 951a3bc to 6213d1e Compare January 31, 2025 03:30
@sapphi-red sapphi-red changed the base branch from main to 01-31-fix_minifier_fix_var_undefined_1_foo_null_foo_undefined_should_not_be_compressed January 31, 2025 03:30
@sapphi-red sapphi-red mentioned this pull request Jan 31, 2025
Merged
@sapphi-red sapphi-red marked this pull request as ready for review January 31, 2025 03:38
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8801 will not alter performance

Comparing 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ (72d74a2) with main (a861d93)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen changed the base branch from 01-31-fix_minifier_fix_var_undefined_1_foo_null_foo_undefined_should_not_be_compressed to graphite-base/8801 January 31, 2025 04:06
@Boshen Boshen force-pushed the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch from 6213d1e to acbd198 Compare January 31, 2025 04:13
@Boshen Boshen force-pushed the graphite-base/8801 branch from 351ffaf to 2eac9c0 Compare January 31, 2025 04:13
@Boshen Boshen changed the base branch from graphite-base/8801 to main January 31, 2025 04:14
@Boshen Boshen force-pushed the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch from acbd198 to 7b1f68e Compare January 31, 2025 04:14
@sapphi-red sapphi-red force-pushed the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch 2 times, most recently from e4cd785 to 6f26411 Compare January 31, 2025 06:40
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 31, 2025
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 31, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 31, 1:47 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 31, 1:47 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 31, 1:52 AM EST: A user merged this pull request with the Graphite merge queue.

@sapphi-red
feat(minifier): compress a != null ? a : b into a ?? b (#8801)
72d74a2 
It seems this was implemented in past by #8352 and was reverted in #8411. I'm not sure what was buggy, but one difference with this PR is that the previous PR doesn't check whether the identifier is a global reference or not.
@graphite-app graphite-app bot force-pushed the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch from 6f26411 to 72d74a2 Compare January 31, 2025 06:47
@graphite-app graphite-app bot merged commit 72d74a2 into main Jan 31, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-31-feat_minifier_compress_a_null_a_b_into_a_b_ branch January 31, 2025 06:52
@sapphi-red sapphi-red mentioned this pull request Jan 31, 2025
Merged
@oxc-bot oxc-bot mentioned this pull request Feb 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @Boshen