• perf(sourcemap): improve perf of search_original_line_and_column #7926
• refactor(benchmark): transform code before codegen #7934 👈 (View in Graphite)
• main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

CodSpeed Performance Report

Merging #7934 will not alter performance

_{Comparing c/12-16-refactor_benchmark_transform_code_before_codegen (9b3a2be) with main (84b75a0)}

Summary

✅ 29 untouched benchmarks

I think this is a good change. Our codegen_sourcemap benchmark previously was unrealistic because the AST it printed had no modifications made to it after the parser. In real world, I assume you always modify the AST in some way before codegen. What would be the point of parsing a file and printing it again if nothing changes in between?

But @Boshen can you confirm you agree?

Merge activity

• Dec 16, 7:51 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 16, 8:07 AM EST: A user added this pull request to the Graphite merge queue.
• Dec 16, 8:12 AM EST: A user merged this pull request with the Graphite merge queue.