Skip to content

feat(semantic): add node_id to Reference #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

feat(semantic): add node_id to Reference #689

merged 1 commit into from
Aug 5, 2023

Conversation

makotot
Copy link
Contributor

@makotot makotot commented Aug 4, 2023 •
edited
Loading

Closes #685

Intend to use this in the following ways in #672.

let node = ctx.nodes().get_node(reference.node_id());
if !self.type_of && has_typeof_operator(node, ctx) {
    return;
}

@github-actions github-actions bot added A-semantic Area - Semantic A-minifier Area - Minifier labels Aug 4, 2023
@makotot makotot changed the title feat(semantic): add node_id to Reference feat(semantic): add node_id to Reference Aug 4, 2023
@makotot makotot marked this pull request as ready for review August 4, 2023 13:38
@Boshen Boshen merged commit c5ff534 into oxc-project:main Aug 5, 2023
@Boshen
Copy link
Member

Boshen commented Aug 5, 2023

Thank you! This is what we need!

@makotot makotot deleted the semantic/reference/nodeid branch August 5, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-minifier Area - Minifier A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(semantic): add AstNodeId to Reference
2 participants
@makotot @Boshen