Skip to content

Conversation

KubaJastrz
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label May 5, 2024
Copy link

codspeed-hq bot commented May 6, 2024

CodSpeed Performance Report

Merging #3167 will not alter performance

Comparing KubaJastrz:eslint-radix (9c7dfda) with main (5081652)

Summary

✅ 27 untouched benchmarks

@KubaJastrz KubaJastrz changed the title eslint-radix rule (wip) feat(linter): add radix rule May 6, 2024
@KubaJastrz KubaJastrz marked this pull request as ready for review May 6, 2024 21:10
@Boshen Boshen enabled auto-merge (squash) May 7, 2024 02:45
@Boshen
Copy link
Member

Boshen commented May 7, 2024

error: binary comparison to literal `Option::None`
  --> crates/oxc_linter/src/rules/eslint/radix.rs:77:24
   |
77 |                     if ctx.symbols().get_symbol_id_from_name("parseInt") == None {
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `ctx.symbols().get_symbol_id_from_name("parseInt").is_none()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
   = note: `-D clippy::partialeq-to-none` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::partialeq_to_none)]`

quick clippy fix.

run just lint

auto-merge was automatically disabled May 7, 2024 06:11

Head branch was pushed to by a user without write access

@Boshen
Copy link
Member

Boshen commented May 8, 2024

Thank you!

@Boshen Boshen merged commit 7113e85 into oxc-project:main May 8, 2024
@KubaJastrz KubaJastrz deleted the eslint-radix branch May 8, 2024 15:54
Brooooooklyn referenced this pull request in toeverything/AFFiNE May 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.3.2` -> `0.3.5`](https://renovatebot.com/diffs/npm/oxlint/0.3.2/0.3.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/oxlint/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/oxlint/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/oxlint/0.3.2/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/oxlint/0.3.2/0.3.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>oxc-project/oxc (oxlint)</summary>

### [`v0.3.5`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.5): oxlint v0.3.5

[Compare Source](https://togithub.com/oxc-project/oxc/compare/7193d75e9444ae8c2ba757b3bc64459abd0e128a...754d9f4c98aab052cf6b2756f7af12557042708d)

#### What's Changed

-   feat(linter): add use-isnan fixer for (in)equality operations by [@&#8203;DonIsaac](https://togithub.com/DonIsaac) in [https://github.com/oxc-project/oxc/pull/3284](https://togithub.com/oxc-project/oxc/pull/3284)
-   feat(linter/eslint): Implement fixer for unicode-bom rule by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3259](https://togithub.com/oxc-project/oxc/pull/3259)
-   fix(linter/no-direct-mutation-state): false positive when class is declared inside a `CallExpression` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3294](https://togithub.com/oxc-project/oxc/pull/3294)
-   fix(parser): parse `DecoratorCallExpression` when `Arguments` contains `MemberExpression` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3265](https://togithub.com/oxc-project/oxc/pull/3265)
-   perf(ast): inline all `ASTBuilder` methods by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3295](https://togithub.com/oxc-project/oxc/pull/3295)
-   perf(lexer): dedupe numeric separator check by [@&#8203;DonIsaac](https://togithub.com/DonIsaac) in [https://github.com/oxc-project/oxc/pull/3283](https://togithub.com/oxc-project/oxc/pull/3283)
-   perf(linter): rewrite react/require-render-return by [@&#8203;mysteryven](https://togithub.com/mysteryven) in [https://github.com/oxc-project/oxc/pull/3276](https://togithub.com/oxc-project/oxc/pull/3276)

#### New Contributors

-   [@&#8203;g-plane](https://togithub.com/g-plane) made their first contribution in [https://github.com/oxc-project/oxc/pull/3268](https://togithub.com/oxc-project/oxc/pull/3268)

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.4...oxlint_v0.3.5

### [`v0.3.4`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.4): oxlint v0.3.4

[Compare Source](https://togithub.com/oxc-project/oxc/compare/6149e49ef79a22004e36820c81afcb0c755fcc81...7193d75e9444ae8c2ba757b3bc64459abd0e128a)

#### What's Changed

-   [feat(linter): move react/rules_of_hooks to nursery](https://togithub.com/oxc-project/oxc/commit/6edcae86cda8922ea8f9e5eae91290018e1b1637)
-   feat(linter/eslint): Implement max-classes-per-file by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3241](https://togithub.com/oxc-project/oxc/pull/3241)
-

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.3...oxlint_v0.3.4

***

### From v0.3.3

#### What's Changed

##### Features

-   add `--symlinks` to allow symbolic walking by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3244](https://togithub.com/oxc-project/oxc/pull/3244)
-   add `--format github` for github check annotation by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3191](https://togithub.com/oxc-project/oxc/pull/3191)
-   change the category of all react-perf rules to perf by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3243](https://togithub.com/oxc-project/oxc/pull/3243)
-   remove deprecated eslint v9 rules `no-return-await` and `no-mixed-operators` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3188](https://togithub.com/oxc-project/oxc/pull/3188)
-   move prefer-node-protocol to restriction by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3171](https://togithub.com/oxc-project/oxc/pull/3171)

##### New Rules

-   react/rules-of-hooks by [@&#8203;rzvxa](https://togithub.com/rzvxa) in [https://github.com/oxc-project/oxc/pull/3071](https://togithub.com/oxc-project/oxc/pull/3071)
-   eslint/radix by [@&#8203;KubaJastrz](https://togithub.com/KubaJastrz) in [https://github.com/oxc-project/oxc/pull/3167](https://togithub.com/oxc-project/oxc/pull/3167)
-   eslint/no-new-native-nonconstructor by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3187](https://togithub.com/oxc-project/oxc/pull/3187)
-   eslint/unicode-bom by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3239](https://togithub.com/oxc-project/oxc/pull/3239)
-   eslint/no-empty-function rule by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3181](https://togithub.com/oxc-project/oxc/pull/3181)
-   eslint-plugin-next/no-duplicate-head by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3174](https://togithub.com/oxc-project/oxc/pull/3174)
-   eslint-plugin-next/no-page-custom-font by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3185](https://togithub.com/oxc-project/oxc/pull/3185)
-   eslint-plugin-next/no-styled-jsx-in-document by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3184](https://togithub.com/oxc-project/oxc/pull/3184)
-   unicorn/no-anonymous-default-export by [@&#8203;1zumii](https://togithub.com/1zumii) in [https://github.com/oxc-project/oxc/pull/3220](https://togithub.com/oxc-project/oxc/pull/3220)

##### Bug Fixes

-   improve `prefer-string-starts-ends-with` rule by [@&#8203;camc314](https://togithub.com/camc314) in [https://github.com/oxc-project/oxc/pull/3176](https://togithub.com/oxc-project/oxc/pull/3176)
-   import/export: improve multiple exports error message by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3160](https://togithub.com/oxc-project/oxc/pull/3160)
-   import/named: handle `import { default as foo }` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3255](https://togithub.com/oxc-project/oxc/pull/3255)
-   shorten eslint/eqeqeq rule error message's span by [@&#8203;mysteryven](https://togithub.com/mysteryven) in [https://github.com/oxc-project/oxc/pull/3193](https://togithub.com/oxc-project/oxc/pull/3193)
-   fix(parser): correctly parse cls.fn<C> = x by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3208](https://togithub.com/oxc-project/oxc/pull/3208)

#### New Contributors

-   [@&#8203;KubaJastrz](https://togithub.com/KubaJastrz) made their first contribution in [https://github.com/oxc-project/oxc/pull/3167](https://togithub.com/oxc-project/oxc/pull/3167)
-   [@&#8203;1zumii](https://togithub.com/1zumii) made their first contribution in [https://github.com/oxc-project/oxc/pull/3220](https://togithub.com/oxc-project/oxc/pull/3220)

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.2...oxlint_v0.3.3

### [`v0.3.3`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.3.3): oxlint v0.3.3

[Compare Source](https://togithub.com/oxc-project/oxc/compare/a7940868c6e66d16814ebef5c8dbbfd9b948a0cd...6149e49ef79a22004e36820c81afcb0c755fcc81)

#### What's Changed

##### Features

-   add `--symlinks` to allow symbolic walking by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3244](https://togithub.com/oxc-project/oxc/pull/3244)
-   add `--format github` for github check annotation by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3191](https://togithub.com/oxc-project/oxc/pull/3191)
-   change the category of all react-perf rules to perf by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3243](https://togithub.com/oxc-project/oxc/pull/3243)
-   remove deprecated eslint v9 rules `no-return-await` and `no-mixed-operators` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3188](https://togithub.com/oxc-project/oxc/pull/3188)
-   move prefer-node-protocol to restriction by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3171](https://togithub.com/oxc-project/oxc/pull/3171)

##### New Rules

-   react/rules-of-hooks by [@&#8203;rzvxa](https://togithub.com/rzvxa) in [https://github.com/oxc-project/oxc/pull/3071](https://togithub.com/oxc-project/oxc/pull/3071)
-   eslint/radix by [@&#8203;KubaJastrz](https://togithub.com/KubaJastrz) in [https://github.com/oxc-project/oxc/pull/3167](https://togithub.com/oxc-project/oxc/pull/3167)
-   eslint/no-new-native-nonconstructor by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3187](https://togithub.com/oxc-project/oxc/pull/3187)
-   eslint/unicode-bom by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3239](https://togithub.com/oxc-project/oxc/pull/3239)
-   eslint/no-empty-function rule by [@&#8203;jelly](https://togithub.com/jelly) in [https://github.com/oxc-project/oxc/pull/3181](https://togithub.com/oxc-project/oxc/pull/3181)
-   eslint-plugin-next/no-duplicate-head by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3174](https://togithub.com/oxc-project/oxc/pull/3174)
-   eslint-plugin-next/no-page-custom-font by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3185](https://togithub.com/oxc-project/oxc/pull/3185)
-   eslint-plugin-next/no-styled-jsx-in-document by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3184](https://togithub.com/oxc-project/oxc/pull/3184)
-   unicorn/no-anonymous-default-export by [@&#8203;1zumii](https://togithub.com/1zumii) in [https://github.com/oxc-project/oxc/pull/3220](https://togithub.com/oxc-project/oxc/pull/3220)

##### Bug Fixes

-   improve `prefer-string-starts-ends-with` rule by [@&#8203;camc314](https://togithub.com/camc314) in [https://github.com/oxc-project/oxc/pull/3176](https://togithub.com/oxc-project/oxc/pull/3176)
-   import/export: improve multiple exports error message by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3160](https://togithub.com/oxc-project/oxc/pull/3160)
-   import/named: handle `import { default as foo }` by [@&#8203;Boshen](https://togithub.com/Boshen) in [https://github.com/oxc-project/oxc/pull/3255](https://togithub.com/oxc-project/oxc/pull/3255)
-   shorten eslint/eqeqeq rule error message's span by [@&#8203;mysteryven](https://togithub.com/mysteryven) in [https://github.com/oxc-project/oxc/pull/3193](https://togithub.com/oxc-project/oxc/pull/3193)
-   fix(parser): correctly parse cls.fn<C> = x by [@&#8203;Dunqing](https://togithub.com/Dunqing) in [https://github.com/oxc-project/oxc/pull/3208](https://togithub.com/oxc-project/oxc/pull/3208)

#### New Contributors

-   [@&#8203;KubaJastrz](https://togithub.com/KubaJastrz) made their first contribution in [https://github.com/oxc-project/oxc/pull/3167](https://togithub.com/oxc-project/oxc/pull/3167)
-   [@&#8203;1zumii](https://togithub.com/1zumii) made their first contribution in [https://github.com/oxc-project/oxc/pull/3220](https://togithub.com/oxc-project/oxc/pull/3220)

**Full Changelog**: oxc-project/oxc@oxlint_v0.3.2...oxlint_v0.3.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5IiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants