Skip to content

feat: introduce --react-perf-plugin CLI flag, update rules to correctness #2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 22, 2024
Merged

feat: introduce --react-perf-plugin CLI flag, update rules to correctness #2119

merged 14 commits into from
Jan 22, 2024

Conversation

byteHulk
Copy link
Contributor

@byteHulk byteHulk commented Jan 22, 2024 •
edited
Loading

byteHulk added 12 commits January 18, 2024 18:06
@byteHulk
feat: add no new fun as props with react perf (oxc-project#2045)
5f88f06
@byteHulk
feat: add react perf rule
7f89fb4
@byteHulk
feat: update error message
1aa464c
@byteHulk
Merge branch 'main' into feat/linter-eslint-plugin-react-perf
1d13fa2
@byteHulk
feat: add error messages and help
d7f2d7c
@byteHulk
Merge branch 'feat/linter-eslint-plugin-react-perf' of https://github…
c652c3b 
….com/byteHulk/oxc into feat/linter-eslint-plugin-react-perf
@byteHulk
chore(style): adjust code formatting
fab8e9c
@byteHulk
Merge branch 'main' into feat/linter-eslint-plugin-react-perf
d2b318a
@byteHulk
fix: fix bugs in expressions that may have braces
b0859b1
@byteHulk
Merge branch 'main' into feat/linter-eslint-plugin-react-perf
2c8ce0e
@byteHulk
Merge branch 'feat/linter-eslint-plugin-react-perf' of https://github…
a873362 
….com/byteHulk/oxc into feat/linter-eslint-plugin-react-perf
@byteHulk
feat: introduce --react-perf-plugin CLI flag, update rules to correct…
d00103c 
…ness
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Jan 22, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2119 will not alter performance

Comparing byteHulk:feat/linter-eslint-plugin-react-perf (4954715) with main (766ca63)

Summary

✅ 17 untouched benchmarks

Boshen
Boshen approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Boshen Boshen merged commit 20a34b5 into oxc-project:main Jan 22, 2024
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@byteHulk @IWANABETHATGUY
feat: introduce --react-perf-plugin CLI flag, update rules to correct…
da8ca91 
…ness (oxc-project#2119)

oxc-project#2041 (comment)

Closes oxc-project#2041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-cli Area - CLI A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☂️ eslint-plugin-react-perf
2 participants
@byteHulk @Boshen