feat: add scope tracker #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/index.ts
…nParam positions as experimental
|
Initially we had a MagicString object because this was something oxc-parser was considering doing, for performance reasons (the sourcemap could be created in Rust). But now this is dropped, and I think it best to keep the walker minimal. |
danielroe
reviewed
May 31, 2025
danielroe
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the implementation of the ScopeTracker from
Nuxtinto theoxc-walker.I have refactored it and cleaned it up slightly.
The
ScopeTrackerclass enables convenient tracking of declared identifiers and accessing their relevant nodes' start / end positions to make code transformations easier. For example, it stores a declaration of a variable, and then allows easy access to a customScopeTrackerVariablenode, which provides access to the string positions of the whole VariableDeclaration, based on the identifier name.