Fix issues with image2card.sh #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The invalid |
jpmens
reviewed
Jan 1, 2025
176ea5d to
5e72525
Compare
Changes:
- Fix invalid json generated by image2card.sh (s/,/:/)
- Make sure that image conversion works when supplied images
are not JPG.
- Adjust comments based on the current documentation:
https://owntracks.org/booklet/features/card/#shell-script
5e72525 to
50fb4b6
Compare
|
Merged, thank you! (and thanks for the |
jpmens
added a commit
that referenced
this pull request
Mar 19, 2025
- NEW: support for inline image data in a POI location publishes - FIX: image2card.sh was creating invalid JSON (#520) - UPD: deprecate google maps from vmap.html (#512) - FIX: install unit file into /etc/systemd/system/ot-recorder.service during fpm (#514) - FIX: fix permissions on files installed to share/docs/ot-recorder (#513) - FIX: contrib/faces/github2card.py require TID - FIX: contrib/faces/gravatar2card.sh require TID and replace MD5 by SHA256 for Gravatar - FIX: contrib/faces/image2card.sh asks for TID to produce CARD - UPD: changed 'convert' in image2card.sh to 'magick' - FIX: consolidate raspbian/debian fpm-make invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
image2card.sh(s/,/:/)