Skip to content

feat: limit tag chars #12474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

feat: limit tag chars #12474

merged 1 commit into from
Apr 14, 2025

Conversation

LukasHirt
Copy link
Collaborator

Description

Read limit set via config from capabilities and apply it to resource tags. Defaults to 30.

Motivation and Context

Secure web app.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: set oCIS config to limit chars to 8 and try to create tag with >= 9 chars

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Apr 14, 2025
@LukasHirt LukasHirt requested review from mzner and Copilot April 14, 2025 08:25
@LukasHirt LukasHirt self-assigned this Apr 14, 2025
Copilot
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

@LukasHirt
feat: limit tag chars
65fa646 
Read limit set via config from capabilities and apply it to resource tags. Defaults to 30.
@LukasHirt LukasHirt force-pushed the feat/tag-chars-limit branch from b1c0a4b to 65fa646 Compare April 14, 2025 08:56
@LukasHirt LukasHirt enabled auto-merge April 14, 2025 09:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt merged commit aa9e52c into master Apr 14, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/tag-chars-limit branch April 14, 2025 09:11
@LukasHirt LukasHirt mentioned this pull request May 20, 2025
Closed
8 tasks
@PrajwolAmatya PrajwolAmatya mentioned this pull request Jun 10, 2025
Closed
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@mzner mzner mzner approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @mzner