fix: drop links advanced mode #12326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
commented
Mar 18, 2025
| expect(wrapper.find(selectors.passwordInput).exists()).toBeTruthy() | ||
| }) | ||
| it('should not be rendered if user cannot create public links', () => { |
There was a problem hiding this comment.
Dropping these tests as they seem to have been false positives. Permissions do not have any effect on the visibility of those fields.
Drop the advanced mode and display password and expiration fields immediately. Also, stop revealing password inside of the password input after generating a password.
db5dec9 to
7edde36
Compare
mzner
approved these changes
Mar 18, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop the advanced mode and display password and expiration fields immediately. Also, stop revealing password inside of the password input after generating a password.
Related Issue
Motivation and Context
Streamlined process and secure password generation
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes