Skip to content

Source string inconsistency found possibly due to renaming in ocis #12100

@mmattel

Description

@mmattel

While checking a users role in the web UI:

image

We found that all strings get translated but not User Light.

While searching, we found that this string is not homed in the ocis repo but must be here in web.
BUT this string has, as it seems, a different name and therefore is not easy identifyable.

In particular, this is in packages/web-runtime/src/helpers/additionalTranslations.ts

image

To my reading, Guests equals User Light and as far I can remember, there was a discussion about renaming in the ocis repo a while ago which happened, but seems that it did not go into web.
https://github.com/search?q=repo%3Aowncloud%2Focis+guest&type=code

This should be harmonized and fixed so teh string becomes translatable.
Note that, as it seems, we should not just rename the key/value as the key seems to be "used" in some locations, though we can give the value a different name (plus a comment about the change). This must be proven with tests.

@2403905 @kobergj @LukasHirt

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type:BugSomething isn't working

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions